PMD Results

The following document contains the results of PMD 4.2.2.

Files

com/gisgraphy/domain/geoloc/entity/Adm.java

Violation Line
An empty statement (semicolon) not part of a loop 201
Avoid empty catch blocks 333 - 334

com/gisgraphy/domain/geoloc/entity/GisFeature.java

Violation Line
An empty statement (semicolon) not part of a loop 541

com/gisgraphy/domain/geoloc/importer/AbstractImporterProcessor.java

Violation Line
Avoid empty catch blocks 402 - 404
Avoid empty catch blocks 565 - 567
Avoid empty catch blocks 572 - 574

com/gisgraphy/domain/geoloc/importer/AdmExtracter.java

Violation Line
Avoid unnecessary return statements 464

com/gisgraphy/domain/geoloc/importer/GeonamesAdm2Importer.java

Violation Line
Do not use if statements that are always true or always false 129

com/gisgraphy/domain/geoloc/importer/GeonamesFeatureImporter.java

Violation Line
Avoid empty catch blocks 251 - 252
These nested if statements could be combined 254 - 261
Avoid empty catch blocks 549 - 550

com/gisgraphy/domain/geoloc/service/fulltextsearch/OutputstreamResponseWrapper.java

Violation Line
Avoid empty catch blocks 95 - 97
Avoid empty catch blocks 114 - 115
Avoid empty catch blocks 120 - 122

com/gisgraphy/domain/geoloc/service/geoloc/GeolocResultsDtoSerializer.java

Violation Line
Avoid unnecessary return statements 131
Avoid unused method parameters such as 'indent'. 145 - 169

com/gisgraphy/domain/geoloc/service/geoloc/StreetSearchResultsDtoSerializer.java

Violation Line
Avoid unnecessary return statements 125
Avoid unused method parameters such as 'indent'. 139 - 163

com/gisgraphy/domain/geoloc/service/geoloc/street/StreetType.java

Violation Line
Avoid empty catch blocks 46 - 47

com/gisgraphy/domain/repository/IDao.java

Violation Line
Avoid unused imports such as 'java.sql.SQLException' 29
Avoid unused imports such as 'org.hibernate.HibernateException' 36
Avoid unused imports such as 'org.springframework.dao.DataAccessException' 38

com/gisgraphy/domain/repository/ImporterStatusListDao.java

Violation Line
These nested if statements could be combined 76 - 79

com/gisgraphy/domain/valueobject/GisFeatureDistance.java

Violation Line
Avoid empty catch blocks 471 - 472

com/gisgraphy/domain/valueobject/Output.java

Violation Line
Avoid empty catch blocks 356 - 357
Avoid empty catch blocks 619 - 620

com/gisgraphy/domain/valueobject/Pagination.java

Violation Line
Avoid unused private methods such as 'from(int)'. 179
Avoid unused private methods such as 'to(int)'. 193

com/gisgraphy/service/impl/BaseManagerMockTestCase.java

Violation Line
Avoid empty catch blocks 54 - 56

com/gisgraphy/webapp/action/ReverseGeocodingAction.java

Violation Line
Avoid unused private fields such as 'logger'. 43

com/gisgraphy/webapp/action/UserAction.java

Violation Line
These nested if statements could be combined 67 - 70
These nested if statements could be combined 126 - 135

com/gisgraphy/webapp/listener/UserCounterListener.java

Violation Line
These nested if statements could be combined 215 - 219

com/gisgraphy/webapp/taglib/CountryTag.java

Violation Line
Overriding method merely calls super 151 - 153

com/gisgraphy/webapp/util/RequestUtil.java

Violation Line
These nested if statements could be combined 90 - 94

com/opensymphony/module/sitemesh/filter/PageFilterWithoutSession.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 180 - 181
These nested if statements could be combined 209 - 211